-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODEOWNERS with list of maintainers #7439
base: master
Are you sure you want to change the base?
Conversation
just merge this? |
Not much has changed since #6830 which did not receive approval. |
I'm not sure why that PR was closed. The discussion turned into enabling an automatic reviewer assignment. To enable this it needs to configure a team. Here I recreated the PR because even without this step this is just a list of github nicknames of maintainers. If some maintainer is not active anymore we can remove it from the list and from the package maintainer field. Anyway if someone creates a PR they'll find same persons and CC them. But we can simplify this step. |
I guess this is in the catagory "better than nothing". But anyway, somebody needs to make decision, either merge or not. Waiting for the all singing and dancing solution will likely mean nothing will happen. |
The CODEOWNERS will request for a review automatically by a path. Signed-off-by: Sergey Ponomarev <[email protected]>
Signed-off-by: Sergey Ponomarev <[email protected]>
I've read earlier revisions of info on this document and found some things left unexplained. More recent revisions seem much more clear. But... unless a user mentioned in the CODEOWNERS file has write permissions to this repo, it's nothing more than a glorified reference document (so no behaviour changes will result, at present standards; a good thing). The document needs to be maintained, however. Do you commit to maintaining it? |
no problem, please merge |
Signed-off-by: Sergey Ponomarev <[email protected]>
I also added the link to CODEOWNERS to PR template. Maybe it also worth to add a link to issues but we may probably overwhelm maintainers. We better to do a triage ourselves and mention a maintainer if needed. |
The second attempt of the #6830 that was closed after a discussion.
My proposition is to add the CODEOWNERS file to help for contributors to quickly find a maintainer (as I did myself today). Even better, for those devs that already have a write access they'll automatically be assigned as reviewers for a PR for the particular app.
The other steps like creating
luci-dev
team as I described in my comment can be done later. But the CODEOWNERS can start helping us today and save time for contributors. We may add a link to it into the PR template.It won't change anything in terms of security so the PR is safe to merge.